Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the checker #6

Merged
merged 10 commits into from
Feb 18, 2021
Merged

Improvements to the checker #6

merged 10 commits into from
Feb 18, 2021

Conversation

afd
Copy link
Contributor

@afd afd commented Feb 18, 2021

This adds various checks to help ensure that a ShaderTrap program is
well-formed before executing it, such as checking that samplers and
textures exist when setting their parameters, that uniforms exist
before setting their values, etc.

@google-cla
Copy link

google-cla bot commented Feb 18, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Feb 18, 2021
@afd
Copy link
Contributor Author

afd commented Feb 18, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Feb 18, 2021
@afd afd merged commit 90aebc1 into main Feb 18, 2021
@afd afd deleted the checker-tests branch February 18, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant