Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShaderTrap Examples: reduction operation by min and max #71

Merged
merged 10 commits into from
Jun 16, 2021
Merged

ShaderTrap Examples: reduction operation by min and max #71

merged 10 commits into from
Jun 16, 2021

Conversation

sliu-UIUC
Copy link
Contributor

Addresses part of #70 by adding reduction examples using min and max operation.

@google-cla google-cla bot added the cla: yes label Jun 9, 2021
@sliu-UIUC sliu-UIUC changed the title ShaderTrap Exaples: reduction operation by min and max ShaderTrap Examples: reduction operation by min and max Jun 10, 2021
afd
afd suggested changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@afd afd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I think it would be good to scramble the input data a little bit, so that it's not always the first array element that is the minimum.

Also the comments need to be updated - at present they refer to addition and summation.

examples/OpenGL45/arrayReductionByMax_version1.shadertrap Outdated Show resolved Hide resolved
examples/OpenGL45/arrayReductionByMax_version3.shadertrap Outdated Show resolved Hide resolved
examples/OpenGL45/arrayReductionByMax_version3.shadertrap Outdated Show resolved Hide resolved
afd
afd suggested changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@afd afd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I have mainly the same feedback as for the other PR - if you can address it, we should be good to merge.

examples/OpenGL45/arrayReductionByMax_version2.shadertrap Outdated Show resolved Hide resolved
examples/OpenGL45/arrayReductionByMin_version1.shadertrap Outdated Show resolved Hide resolved
afd
afd approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@afd afd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution!

@afd afd merged commit f507264 into google:main Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afd afd afd approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sliu-UIUC @afd