(Re)Connecting Analytics hangs in loading state when Tag Manager Is connected

[zutigrm]

Bug Description

When Tag Manager module is connected, and Analytics disconnected and then, trying to connect again it hangs in the loading state.

There is no console error. When working on IB, check this comment as potential direction

Steps to reproduce

1. Setup Site Kit
2. Connect Analytics and Tag Manager modules
3. Disconnect Analytics module
4. Try to connect it again
5. See setup being stuck in loading state

Screenshots

Screen.Recording.2023-11-30.at.13.09.51.mov

Additional Context

• PHP Version:
• OS: [e.g. iOS]
• Browser: [e.g. chrome, safari]
• Plugin Version: [e.g. 22]
• Device: [e.g. iPhone6]

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• A user should be able to connect or reconnect Analytics after Tag Manager has been set up.

Implementation Brief

• So the issue is that we don't load getLiveContainerVersion anymore and so the loading checks for hasFinishedResolution for this selector returns false because the resolution never started (I confirmed this by calling hasStartedResolution). This is because we do not output the ExistingGTMPropertyNotice anymore, since we removed UA settings which did a property ID check, etc. So removing this check, as done in this PR on the SettingsEdit form is correct.
  • This should also be done on the new analytics-4 component that will be used soon too.
• Since this is a very minor PR, I have gone ahead and attached it here with a QAB.

Test Coverage

• No new tests required.

QA Brief

• Setup Site Kit and connect GTM without connecting Analytics.
  • Verify that connecting Analytics works.
  • Verify that creating a new account works.
  • Verify that editing settings still works.

Changelog entry

• Fix bug preventing Analytics from being setup when Tag Manager is connected.

[zutigrm]

This is just a guess, but this might be regression from removing the ga4Reporting feature flag. We had similar issue, when editing Analytics settings with Tag Manager connected, edit settings would also hang in loading state. This was related to the gtmContainersResolved and it's hasFinishedLoadingGTMContainers check which was not used in GA4, you can check this PR, this might be similarly relating to this as well.

[techanvil]

Hi @jimmymadon, this IB looks good. One thing, though - with hasFinishedLoadingGTMContainers() no longer in use, we should remove that too (both versions of it).

Tbh, this can be a detail for the PR - I'll approve the IB ✅ and move this to Execution for an update.

[jimmymadon]

Hi @jimmymadon, this IB looks good. One thing, though - with hasFinishedLoadingGTMContainers() no longer in use, we should remove that too (both versions of it).

Tbh, this can be a detail for the PR - I'll approve the IB ✅ and move this to Execution for an update.

Thanks @techanvil, I've replied there.

[mohitwp]

QA Update ✅

• Tested on dev environment.
• On latest environment able to reproduce the issue.
• On dev environment issue is not reproducible and analytics is not getting stuck on reconnecting.

Recording.782.mp4