Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate GoogleAnalyticsAdminV1alphaAdSenseLink for Google API Client Library #8045

Closed
4 tasks done
tofumatt opened this issue Jan 6, 2024 · 3 comments
Closed
4 tasks done
Labels
Module: AdSense Google AdSense module related issues Module: Analytics Google Analytics module related issues P1 Medium priority PHP Type: Infrastructure Engineering infrastructure & tooling

Comments

@tofumatt
Copy link
Collaborator

tofumatt commented Jan 6, 2024

Feature Description

We need to replicate the Google API Client library's GoogleAnalyticsAdminV1alphaAdSenseLink for the REST Route we'll need to get linked accounts. See: https://docs.google.com/document/d/1-JenwPTAkw0eTkmESzjTOfgphs9qpRYH0h3xk_s3a4o/edit#heading=h.mjj6lw6stv0x


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

  • Generate the Google_GoogleAnalyticsAdminV1alphaAdSenseLink class, and any related dependencies that are missing from our installed version of the Google API Client library.
    • Note that as it's an alpha API it's not in a more recent version so there's no need to upgrade the client library.
    • Use the google-apis-client-generator to generate the code - note that @aaemnnosttv has already generated a Gist of it, which can be used.
  • Create and require the new local Composer package packages/apiclient-services-adsenselinks.
    • Copy the necessary generated files into the package.
    • Tweak PHP Scoper rules as needed to ensure the namespaced version of the package works correctly.
    • Add the package as a dependency to the main composer.json file.
    • See this PR for the previously created packages/apiclient-services-subscribewithgoogle for an example.
  • Create the class Google\Site_Kit\Modules\Analytics_4\GoogleAnalyticsAdmin\AdSenseLinksService This can follow the example of an existing service, say PropertiesEnhancedMeasurementService.
  • Copy the usage of Google_GoogleAnalyticsAdminV1alphaAdSenseLink from the generated Google_Service_GoogleAnalyticsAdmin class into the AdSenseLinksService class.

Test Coverage

  • No test coverage needed here; these can be tested in an integrated test when used in a subsequent issue. However, please do verify the code does indeed work as expected.

QA Brief

  • This does not introduce any user facing changes and only adds infrastructure for subsequent works. No QA needed here.

Changelog entry

  • Add PHP client library for Analytics AdSense links.
@tofumatt tofumatt added P0 High priority PHP Module: Analytics Google Analytics module related issues Module: AdSense Google AdSense module related issues labels Jan 6, 2024
@mxbclang mxbclang added Next Up Issues to prioritize for definition P1 Medium priority and removed P0 High priority labels Jan 8, 2024
@techanvil techanvil assigned techanvil and unassigned aaemnnosttv and techanvil Jan 10, 2024
@eugene-manuilov eugene-manuilov self-assigned this Jan 11, 2024
@eugene-manuilov
Copy link
Collaborator

IB ✔️

@eugene-manuilov eugene-manuilov removed their assignment Jan 11, 2024
@kuasha420 kuasha420 self-assigned this Jan 14, 2024
@kuasha420 kuasha420 added the Type: Infrastructure Engineering infrastructure & tooling label Jan 15, 2024
@kuasha420 kuasha420 removed their assignment Jan 16, 2024
@10upsimon 10upsimon self-assigned this Jan 17, 2024
@mxbclang
Copy link

Unassigned from @10upsimon as he's been ill and we need him focusing on some other work, so anyone else can feel free to pick up, please!

@nfmohit nfmohit self-assigned this Jan 19, 2024
@mxbclang mxbclang removed the Next Up Issues to prioritize for definition label Jan 19, 2024
@nfmohit nfmohit assigned kuasha420 and unassigned nfmohit Jan 21, 2024
@kuasha420 kuasha420 assigned nfmohit and unassigned kuasha420 Jan 21, 2024
@nfmohit nfmohit removed their assignment Jan 22, 2024
@wpdarren
Copy link
Collaborator

Moved to approval as per Slack conversation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: AdSense Google AdSense module related issues Module: Analytics Google Analytics module related issues P1 Medium priority PHP Type: Infrastructure Engineering infrastructure & tooling
Projects
None yet
Development

No branches or pull requests

9 participants