-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTL languages translation for NPT #8664
Labels
Comments
ivonac4
added
Team M
Issues for Squad 2
Next Up
Issues to prioritize for definition
labels
May 6, 2024
IB ✅ |
18 tasks
hussain-t
added a commit
that referenced
this issue
May 24, 2024
techanvil
added a commit
that referenced
this issue
Jun 3, 2024
…m-footer Enhance/#8664 - Fix RTL styles for the Authorize Application screen custom footer
QA Update ✅This is verified good.
Moving this to Approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug Description
When testing in RTL language, the 'Powered by Site Kit' is not properly aligned.
Steps to reproduce
wp-admin/authorize-application.php?app_name=GoogleServiceIntegration&app_id=123e4567-e89b-12d3-a456-426614174000&success_url=https%3A%2F%2Fpublishers.google.com%2Fsettings%2Fauthorization%2Fwordpress&sitekit=true
Screenshots
Currently, the 'Powered by Site Kit' string is here and I think this should be moved to the left to mirror the WordPress version alignment:
For reference, stock styling looks like this:
Additional Context
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
In
assets/sass/authorize-application/_googlesitekit-authorize-application.scss
:.googlesitekit-authorize-application__footer
within thehtml[dir="rtl"]
selector:left: auto
to remove the left positioning.right: 0
to align the text to the right.margin-right: 36px
to reverse the margin applied to the left side in LTR for the smaller screen sizes.$width-desktop + 1 + px
), setmargin-right: 160px
to reverse the margin applied to the left side in LTR.Test Coverage
QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: