Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.128.0 #8740

Closed
aaemnnosttv opened this issue May 20, 2024 · 8 comments
Closed

Release 1.128.0 #8740

aaemnnosttv opened this issue May 20, 2024 · 8 comments
Labels
P0 High priority Type: Task Tasks which do not involve engineering

Comments

@aaemnnosttv
Copy link
Collaborator


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • Release is prepared, tested, and deployed to wordpress.org.

Implementation Brief

  • N/A

QA Brief

  • N/A

Changelog entry

  • N/A
@aaemnnosttv aaemnnosttv added P0 High priority Type: Task Tasks which do not involve engineering labels May 20, 2024
@aaemnnosttv aaemnnosttv self-assigned this May 20, 2024
@wpdarren wpdarren self-assigned this May 30, 2024
@tofumatt tofumatt self-assigned this May 30, 2024
@kelvinballoo kelvinballoo self-assigned this May 30, 2024
@nfmohit nfmohit self-assigned this May 30, 2024
@kuasha420 kuasha420 self-assigned this May 31, 2024
@wpdarren
Copy link
Collaborator

QA Update: ✅

I went through our usual QA checks:

  • Tested on a site in gathering and zero data state
  • Tested on a site with live data
  • Tested Dashboard sharing
  • Tested Ad Blocking Recovery
  • Tested Enhanced Measurement
  • Tested User Input and KMW widget
  • Tested Consent Mode
  • Tested AdSense+GA4 Integration
  • Tested the Ads Module

@wpdarren wpdarren removed their assignment May 31, 2024
@kelvinballoo
Copy link
Collaborator

QA Update ✅

QA Update ✅

Usual tests done included but not limited to:

  • Plugin setup (activation, deactivation, deletion)
  • Disconnect & Reset Plugin
  • Module Connection & Setup for each
  • Ad Blocker testing
  • Help Menu
  • KMW widget
  • Consent mode
  • User Menu
  • Module Settings changes
  • Module Functionality

Nothing to report. LGTM!

@jimmymadon jimmymadon self-assigned this May 31, 2024
@tofumatt
Copy link
Collaborator

QA ✅

  • Went through a new site install and an upgrade, both worked fine
  • Set up all modules
  • Uninstalled and re-installed to test for bugs
  • Some smoke testing
  • Focused on some accessibility testing, all looks good in this one, no regressions 🙂

Looks good 👍🏻

@tofumatt tofumatt removed their assignment May 31, 2024
@hussain-t hussain-t self-assigned this Jun 1, 2024
@nfmohit
Copy link
Collaborator

nfmohit commented Jun 1, 2024

Release Tested ✅

  • Release tested 1.128.0 thoroughly.
  • Set everything up from scratch on a live (TasteWP) site.
  • Didn't spot any unexpected console errors.
  • Verified UI in different device breakpoints.
  • Verified changes I've been involved with.
  • Used the release testing checklist to ensure everything was checked.
  • Tested Dashboard Sharing.
  • Tested GA4 + AdSense integration.
  • Tested Consent Mode.
  • Tested Ads module.
  • Tested KMW.

@nfmohit nfmohit removed their assignment Jun 1, 2024
@hussain-t
Copy link
Collaborator

hussain-t commented Jun 2, 2024

QA Verified ✅

  • Smoke tested.
  • Verified the changes I’ve been involved with.
  • Tested Dashboard sharing
  • Tested Ad Blocking Recovery
  • Tested Enhanced Measurement
  • Tested User Input and KMW widget
  • Tested Consent Mode
  • Tested AdSense+GA4 Integration
  • Tested the Ads Module
  • Performed some ad-hoc testing.

⚠️ I've noticed an issue in the view-only dashboard where an API request to the audience-settings endpoint is being made. This request fails due to a permission error. However, this is not a concern for this release since it is gated behind the audienceSegmentation feature flag. Other than that, everything LGTM 👍
cc: @techanvil

Screenshot 2024-06-02 at 11 33 13 PM

@hussain-t hussain-t removed their assignment Jun 2, 2024
@mohitwp
Copy link
Collaborator

mohitwp commented Jun 3, 2024

QA Update ✅

  • Ran QA checklist.
  • Verified setup without analytics.
  • Verified setup with Analytics.
  • Verified all modules setup.
  • Verified updated notice and design for Adblocker notice.
  • Verified zero and gathering data state.
  • Tested using live site.
  • Verified dashboard sharing functionality.

@kuasha420
Copy link
Contributor

Release Testing: ✔️

  • Went through the release testing checklist.
  • Set up All modules. Tested module settings view/edit and disconnection/reconnection.
    • Tested AdSense and Ads module with and without Ad Blocker installed.
  • Tested Ad Blocking Recovery
  • Tested AdSense+GA4 integration
    • Also tested on shared dashboard.
  • Tested updating site kit on an existing site with zip.

LGTM 👍

@kuasha420 kuasha420 removed their assignment Jun 3, 2024
@zutigrm zutigrm self-assigned this Jun 3, 2024
@zutigrm
Copy link
Collaborator

zutigrm commented Jun 3, 2024

QA Verified ✅

  • Smoke tested
  • Tested available modules
  • Tested Key metrics
  • Tested dashboard sharing and entity dashboard
  • Performed ad hoc testing

LGTM

@zutigrm zutigrm removed their assignment Jun 3, 2024
@jimmymadon jimmymadon removed their assignment Jun 3, 2024
@aaemnnosttv aaemnnosttv removed their assignment Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 High priority Type: Task Tasks which do not involve engineering
Projects
None yet
Development

No branches or pull requests

10 participants