Fix EmbindObject's deleteLater to deleteAfter #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR (HEAD: 0b08b6e) has been imported to Gerrit for code review. Please visit review.skia.org/445736 to see it. Please CC yourself to the Gerrit change. Note:
|
|
This PR is being closed because review.skia.org/445736 has been merged. |
blueboxd
pushed a commit
to blueboxd/skia
that referenced
this pull request
Sep 8, 2021
I found that CanvasKit's `EmbindObject` type has wrong function name, `deleteAfter`. I cound't find any information of function `deleteAfter` even in google searching. so i digged it.  I have no idea with `deleteAfter`, but `EmbindObject` has the function name `deleteLater`, not `deleteAfter`. Below is the code of Embind. https://github.com/emscripten-core/emscripten/blob/dd5733ac80881e55e1f6757caabf617b6b2a7cec/src/embind/embind.js#L1782 This is an imported pull request from google#86 GitOrigin-RevId: 0738dc7 Change-Id: I0a7af3d4f313d36e8cdc09d631f9199e948eca29 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/445736 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that CanvasKit's
EmbindObjecttype has wrong function name,deleteAfter.I cound't find any information of function
deleteAftereven in google searching. so i digged it.I have no idea with
deleteAfter, butEmbindObjecthas the function namedeleteLater, notdeleteAfter.Below is the code of Embind.
https://github.com/emscripten-core/emscripten/blob/dd5733ac80881e55e1f6757caabf617b6b2a7cec/src/embind/embind.js#L1782