Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the diode LEF files. #204

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Improve the diode LEF files. #204

merged 1 commit into from
Nov 4, 2020

Conversation

mithro
Copy link
Contributor

@mithro mithro commented Nov 4, 2020 •
edited
Loading

This change improves the diode_2 and fill_diode_[248] LEF files in
the sky130_fd_sc_hs and sky130_fd_sc_ms libraries.

These changes include;

  • Adding USE and SHAPE properties.
  • Removing CORE class.
  • Fix layer for power pins.

This fixes #141.

Updating submodules on 2020-11-04 07:12:35 UTC

  • libraries/sky130_fd_sc_hs/latest 2d165a2...98372f0 (1):

    Improve diode LEF files.

  • libraries/sky130_fd_sc_hs/v0.0.1 b81bfbb...7ad9f32 (1):

    Improve diode LEF files.

  • libraries/sky130_fd_sc_hs/v0.0.2 2d165a2...98372f0 (1):

    Improve diode LEF files.

  • libraries/sky130_fd_sc_ms/latest 175daa5...fa42f38 (1):

    Improve diode LEF files.

  • libraries/sky130_fd_sc_ms/v0.0.1 a2ecab1...2fbf638 (1):

    Improve diode LEF files.

  • libraries/sky130_fd_sc_ms/v0.0.2 175daa5...fa42f38 (1):

    Improve diode LEF files.

Signed-off-by: Tim 'mithro' Ansell me@mith.ro

@mithro
Improve the diode LEF files.
66e9d06 
This change improves the `diode_2` and `fill_diode_[248]` LEF files in
the `sky130_fd_sc_hs` and `sky130_fd_sc_ms` libraries.

These changes include;
 * Adding `USE` and `SHAPE` properties.
 * Removing `CORE` class.
 * Fix layer for power pins.

This fixes google#141.

Updating submodules on 2020-11-04 07:12:35 UTC

 - Updating [`sky130_fd_sc_hs` latest](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_sc_hs/+/v0.0.2-46-g2d165a2ff..v0.0.2-48-g98372f073) to v0.0.2-48-g98372f073
 - Updating [`sky130_fd_sc_hs` v0.0.1](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_sc_hs/+/v0.0.1-23-gb81bfbb8d..v0.0.1-24-g7ad9f328a) to v0.0.1-24-g7ad9f328a
 - Updating [`sky130_fd_sc_hs` v0.0.2](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_sc_hs/+/v0.0.2-46-g2d165a2ff..v0.0.2-48-g98372f073) to v0.0.2-48-g98372f073
 - Updating [`sky130_fd_sc_ms` latest](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_sc_ms/+/v0.0.2-48-g175daa5e8..v0.0.2-50-gfa42f3825) to v0.0.2-50-gfa42f3825
 - Updating [`sky130_fd_sc_ms` v0.0.1](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_sc_ms/+/v0.0.1-24-ga2ecab114..v0.0.1-25-g2fbf63838) to v0.0.1-25-g2fbf63838
 - Updating [`sky130_fd_sc_ms` v0.0.2](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_sc_ms/+/v0.0.2-48-g175daa5e8..v0.0.2-50-gfa42f3825) to v0.0.2-50-gfa42f3825

 * libraries/sky130_fd_sc_hs/latest 2d165a2...98372f0 (1):
   > Improve diode LEF files.

 * libraries/sky130_fd_sc_hs/v0.0.1 b81bfbb...7ad9f32 (1):
   > Improve diode LEF files.

 * libraries/sky130_fd_sc_hs/v0.0.2 2d165a2...98372f0 (1):
   > Improve diode LEF files.

 * libraries/sky130_fd_sc_ms/latest 175daa5...fa42f38 (1):
   > Improve diode LEF files.

 * libraries/sky130_fd_sc_ms/v0.0.1 a2ecab1...2fbf638 (1):
   > Improve diode LEF files.

 * libraries/sky130_fd_sc_ms/v0.0.2 175daa5...fa42f38 (1):
   > Improve diode LEF files.

Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
@mithro mithro added type-bug Something isn't working lib-sky130_fd_sc_hs Issues with the "high speed" digital standard cells provided by the SkyWater foundry. lib-sky130_fd_sc_ms Issues with the "medium speed" digital standard cells provided by the SkyWater foundry. files-layout-lef Issues related to Library Exchange Format (LEF) files. files-layout-lef-magic Issues related to the Library Exchange Format (LEF) files generated by Magic. labels Nov 4, 2020
@mithro mithro requested a review from msaligane November 4, 2020 07:17
@mithro mithro self-assigned this Nov 4, 2020
@msaligane
Copy link
Collaborator

@mithro LGTM!

msaligane
msaligane approved these changes Nov 4, 2020
View reviewed changes
Copy link
Collaborator

@msaligane msaligane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have read the hs and hd libs and run a design for each of these two libraries with the cmd:
repair_antennas sky130_fd_sc_hs__diode_2/DIODE
This works fine.
I also loaded the lef of the other libs in openroad and they did not report any issues.

@mithro mithro merged commit 4957ac8 into google:master Nov 4, 2020
@mithro
Copy link
Contributor Author

mithro commented Nov 4, 2020

@agorararmard -- I think you will need to update open_pdks now this has been merged.

@mithro mithro mentioned this pull request Nov 4, 2020
Closed
@mithro mithro deleted the diode-lef-fixes branch November 4, 2020 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msaligane msaligane msaligane approved these changes

Assignees

@mithro mithro

Labels
files-layout-lef Issues related to Library Exchange Format (LEF) files. files-layout-lef-magic Issues related to the Library Exchange Format (LEF) files generated by Magic. lib-sky130_fd_sc_hs Issues with the "high speed" digital standard cells provided by the SkyWater foundry. lib-sky130_fd_sc_ms Issues with the "medium speed" digital standard cells provided by the SkyWater foundry. type-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sky130_fd_sc_hs/latest random LEF issues in fill_diode and diode cells
2 participants
@mithro @msaligane