-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version number to 1.2.0 #178
Conversation
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Thank you! Sorry for the confusion, I inherited the project and forgot about that Can you sign CLA and I'll merge shortly |
No problem. 🙂 I am waiting for a response to know whether I have to sign the CLA on behalf of QuantStack or not. |
Hi @danlark1 , I just have signed the CLA. |
git clean -xdf git submodule sync --recursive git submodule update --init --recursive git submodule foreach git checkout -- . tar zcvf ../snappy_1.2.0.orig.tar.gz --exclude=.git . debuild -uc -us cp snappy.spec ../snappy_1.2.0-1.spec cp ../*snappy*1.2.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/google-snappy-1.2.0/ rm -rf ../*snappy*1.2.0*.* See google#178 Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
The check still fails, can you take a look if the email you signed with matches the one of the commit? |
Done. |
Thanks! |
You are welcome. |
1.2.0 was released recently, but the version number was not updated, causing some inconsistency for the soname of the dynamic shared library.