Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic implement for support tag in Space #47

Merged
merged 19 commits into from
Jan 9, 2024
Merged

Add basic implement for support tag in Space #47

merged 19 commits into from
Jan 9, 2024

Conversation

huan233usc
Copy link
Collaborator

Scope of pr

  • allow add and remove a tag for a snapshot, current snapshot
  • read using a tag

@huan233usc huan233usc requested a review from coufon January 6, 2024 21:38
coufon
coufon requested changes Jan 6, 2024
View reviewed changes
python/src/space/core/proto/runtime.proto Outdated Show resolved Hide resolved
python/src/space/core/runners.py Outdated Show resolved Hide resolved
python/src/space/core/runners.py Outdated Show resolved Hide resolved
python/src/space/core/runners.py Outdated Show resolved Hide resolved
python/src/space/core/storage.py Show resolved Hide resolved
python/src/space/core/storage.py Outdated Show resolved Hide resolved
python/src/space/core/storage.py Outdated Show resolved Hide resolved
@huan233usc huan233usc requested a review from coufon January 8, 2024 19:33
coufon
coufon requested changes Jan 9, 2024
View reviewed changes
python/src/space/core/proto/metadata.proto Outdated Show resolved Hide resolved
python/src/space/core/proto/metadata.proto Show resolved Hide resolved
python/src/space/core/proto/metadata.proto Show resolved Hide resolved
python/src/space/core/proto/metadata.proto Show resolved Hide resolved
python/src/space/core/runners.py Outdated Show resolved Hide resolved
python/src/space/core/runners.py Outdated Show resolved Hide resolved
python/src/space/core/runners.py Outdated Show resolved Hide resolved
python/src/space/core/storage.py Show resolved Hide resolved
python/src/space/core/storage.py Outdated Show resolved Hide resolved
python/src/space/core/storage.py Outdated Show resolved Hide resolved
@huan233usc huan233usc requested a review from coufon January 9, 2024 05:32
coufon
coufon approved these changes Jan 9, 2024
View reviewed changes
python/src/space/core/datasets.py Outdated Show resolved Hide resolved
python/src/space/core/datasets.py Outdated Show resolved Hide resolved
python/src/space/core/datasets.py Outdated Show resolved Hide resolved
python/src/space/core/proto/metadata.proto Outdated Show resolved Hide resolved
python/src/space/core/runners.py Outdated Show resolved Hide resolved
python/src/space/ray/runners.py Show resolved Hide resolved
python/src/space/ray/runners.py Show resolved Hide resolved
python/tests/core/test_runners.py Show resolved Hide resolved
python/tests/core/test_storage.py Show resolved Hide resolved
python/tests/core/test_storage.py Show resolved Hide resolved
@coufon
Copy link
Collaborator

coufon commented Jan 9, 2024

Thank you!

@huan233usc huan233usc merged commit 2d47383 into main Jan 9, 2024
5 checks passed
@huan233usc huan233usc deleted the huan233-dev branch January 10, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coufon coufon coufon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huan233usc @coufon