Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix overflow bug in finiteFloatToInt #376

Merged
merged 1 commit into from
May 6, 2021
Merged

fix overflow bug in finiteFloatToInt #376

merged 1 commit into from
May 6, 2021

Conversation

adonovan
Copy link
Collaborator

@adonovan adonovan commented May 5, 2021

Fixes #375

@google-cla
Copy link

google-cla bot commented May 5, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented May 5, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@adonovan adonovan requested a review from jayconrod May 5, 2021 03:00
@jayconrod
Copy link
Collaborator

Code looks good.

It looks like the CLA bot is unhappy though. It can't find a signed CLA for this GitHub ID or the associated email. Let me know if you need for info digging into this on the Google side.

It doesn't look like I have access to override this btw. I'm not sure that's ever granted for repos in the google org; it's been occasionally needed in other orgs (due to CLA bot limitations).

@adonovan
Copy link
Collaborator Author

adonovan commented May 6, 2021

@googlebot I signed it!

@adonovan adonovan merged commit 8464232 into master May 6, 2021
@adonovan adonovan deleted the fix-float-375 branch May 6, 2021 03:45
@adonovan
Copy link
Collaborator Author

adonovan commented May 6, 2021

Thanks Jay; I had just forgotten the "I signed it!" response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

int(9223372036854775807.5) == -9223372036854775808
2 participants