This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
Implement use triple slash for documentation comments #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atamez31
force-pushed
the
implement-UseTripleSlashForDocumentationComments
branch
from
e56b93f
to
1b1ad84
Compare
harlanhaskins
suggested changes
Jul 3, 2018
| return isInvalid ? token.withLeadingTrivia(Trivia.init(pieces: pieces)) : token | ||
| } | ||
|
|
||
| /// Indicates if a doc block comment is between tokens on the same line. |
There was a problem hiding this comment.
Since this is duplicated from NoBlockComments, it might be best to move this into a convenience method inside TokenSyntax+Convenience.swift
| } | ||
|
|
||
| /// Converts the text of doc block comment into a format for a doc line comment. | ||
| func convertsDocBlockCommentToDocLineComment(_ text: String) -> String { |
There was a problem hiding this comment.
Functions should be verbs, so convertDocBlockCommentToDocLineComment.
|
Looks great! |
|
Can you address Harlan's feedback here, and then I'll take a closer look? |
…nt variable from DeclSyntax
allevato
pushed a commit
that referenced
this pull request
Sep 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.