Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prog: fix validation of DataMmapProg #4764

Merged
merged 2 commits into from
May 6, 2024

Conversation

dvyukov
Copy link
Collaborator

@dvyukov dvyukov commented May 6, 2024

Allow to serialize/deserialize DataMmapProg
and fix validation in debug mode.

Fixes #4750

@dvyukov dvyukov requested a review from a-nogikh May 6, 2024 06:35
@dvyukov dvyukov enabled auto-merge May 6, 2024 07:01
prog/prog.go Show resolved Hide resolved
Allow to serialize/deserialize DataMmapProg
and fix validation in debug mode.

Fixes google#4750
@dvyukov dvyukov force-pushed the dvyukov-fix-mmap-prog-validation branch from abf3932 to 33978e4 Compare May 6, 2024 11:11
@dvyukov
Copy link
Collaborator Author

dvyukov commented May 6, 2024

PTAL.

I've prohibited mutation and cloning of unsafe programs (cloning also takes care of MutateWithHints and cloning of corpus programs during mutation).

Also pushed a commit that enables debug checking in all tests.

@dvyukov dvyukov added this pull request to the merge queue May 6, 2024
Merged via the queue into google:master with commit ea57a16 May 6, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: call #0 mmap: ptr vma has bad address 18446744073709547520/4096/4096
2 participants