Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve git file paths to absolute before npm install #206

Merged
merged 1 commit into from
Feb 4, 2021
Merged

Conversation

aomarks
Copy link
Member

@aomarks aomarks commented Feb 1, 2021

Previously, an install error would occur if you specified a dependency substitution like this:

"my-dep": {
  "kind": "git",
  "repo": "../",
  "ref": "main",
  "setupCommands": [
    "npm i",
  ]
}

This happened because when repo is a relative path, it was getting evaluated as-is from the temp directory we generate for each install. Now, we first resolve such relative paths to absolute paths before install.

Fixes #202

cc @43081j

Copy link
Contributor

@cdata cdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aomarks aomarks merged commit 9f29135 into master Feb 4, 2021
@aomarks aomarks deleted the gitfiles branch February 4, 2021 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: Using relative dependencies and git branches
2 participants