Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect relative local git repo paths in a more reliable way #212

Merged
merged 3 commits into from
Apr 22, 2021

Conversation

aomarks
Copy link
Member

@aomarks aomarks commented Apr 22, 2021

Fixes #211

When doing our special git monorepo install logic, we have to resolve local relative repo paths to absolute paths, so that when we reference them from a temp directory, they are pointing to the right location. Previously we did that by assuming anything that wasn't a URL was a local path, but this is actually wrong because of repo specifiers like git@github.com:MyOrg/my-repo.git. Instead, now we check for . prefix, which is simpler and works fine because only filepaths should ever start with a ..

Also bump dependencies and prepare a patch release.

@aomarks aomarks merged commit 3cab8e0 into master Apr 22, 2021
@aomarks aomarks deleted the git-local-resolve branch April 22, 2021 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using SSH in Github dependency resolutions
2 participants