Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update syn 2.0 #427

Merged
merged 1 commit into from
Feb 4, 2024
Merged

update syn 2.0 #427

merged 1 commit into from
Feb 4, 2024

Conversation

getong
Copy link
Contributor

@getong getong commented Feb 3, 2024

No description provided.

@getong getong force-pushed the update-syn-2.0 branch 2 times, most recently from 74d1e87 to 4c3f39a Compare February 3, 2024 15:19
plugins/src/lib.rs Outdated Show resolved Hide resolved
@tikue
Copy link
Collaborator

tikue commented Feb 3, 2024

Thanks very much! Left one review comment regarding literal validation in derive_serde

plugins/src/lib.rs Outdated Show resolved Hide resolved
@getong
Copy link
Contributor Author

getong commented Feb 4, 2024

clap, tokio-serde, console-subscriber, all of them upgrade to new version, since they use syn 1.0, which cause the ci error.
After upgrading new version, the ci is ok now.

tarpc/Cargo.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@tikue tikue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the tokio-serde change

@getong
Copy link
Contributor Author

getong commented Feb 4, 2024

carllerche/tokio-serde#31

I found this pr, but it does not be merged.

@getong
Copy link
Contributor Author

getong commented Feb 4, 2024

@tikue
Everything is ok now

@tikue tikue added this pull request to the merge queue Feb 4, 2024
@tikue
Copy link
Collaborator

tikue commented Feb 4, 2024

Thank you!

Merged via the queue into google:master with commit 1d98501 Feb 4, 2024
33 checks passed
@getong getong deleted the update-syn-2.0 branch February 4, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants