Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement enumumerate() & timestamps() #179

Merged
merged 12 commits into from
Jul 4, 2023
Merged

Implement enumumerate() & timestamps() #179

merged 12 commits into from
Jul 4, 2023

Conversation

DonBraulio
Copy link
Collaborator

No description provided.

@DonBraulio DonBraulio added the enhancement New feature or request label Jul 3, 2023
@DonBraulio DonBraulio self-assigned this Jul 3, 2023
achoum
achoum reviewed Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@achoum achoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome :)

temporian/core/operators/enumerate.py Outdated Show resolved Hide resolved
temporian/core/operators/timestamps.py Outdated Show resolved Hide resolved
temporian/core/operators/timestamps.py Outdated Show resolved Hide resolved
temporian/core/operators/enumerate.py Outdated Show resolved Hide resolved
temporian/core/operators/timestamps.py Show resolved Hide resolved
temporian/implementation/numpy/operators/enumerate.py Outdated Show resolved Hide resolved
@DonBraulio
Copy link
Collaborator Author

Thanks! All suggestions implemented.

achoum
achoum approved these changes Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@achoum achoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.
Looking forward to use those ops :).

Make sure to allign with Ian before submitting as he is working on a code-wide pr.

@ianspektor
Copy link
Collaborator

ianspektor commented Jul 4, 2023 •
edited
Loading

Make sure to merge main and add @compile decorator to new ops before merging 👮🏼

@DonBraulio DonBraulio merged commit c822d62 into main Jul 4, 2023
@DonBraulio DonBraulio deleted the ops_enum_timestamp branch July 4, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achoum achoum achoum approved these changes

Assignees

@DonBraulio DonBraulio

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DonBraulio @ianspektor @achoum