Tensorstore fails to compile as a CMake subproject

[dzenanz]

This is a reappearance of #112 when trying to build tensorstore as a CMake subproject. The same project compiled fine with 2868eab. The issue occurs with 189610c.

dzenan@corista:~/zarr/ngff-build$ ninja -k 99
[2/1395] Building CXX object _deps/upb-build/CMakeFiles/upb_upbc_protoc-gen-upb_stage0.dir/upbc/protoc-gen-upb.cc.o
FAILED: _deps/upb-build/CMakeFiles/upb_upbc_protoc-gen-upb_stage0.dir/upbc/protoc-gen-upb.cc.o 
/usr/bin/c++ -DUPB_BOOTSTRAP_STAGE0 -I/home/dzenan/ITK-git/Modules/ThirdParty/Eigen3/src/itkeigen/.. -I/home/dzenan/ITK-git-rel/Modules/ThirdParty/Eigen3/src -I/home/dzenan/ITK-git-rel/Modules/ThirdParty/KWSys/src -I/home/dzenan/ITK-git/Modules/ThirdParty/VNL/src/vxl/v3p/netlib -I/home/dzenan/ITK-git/Modules/ThirdParty/VNL/src/vxl/vcl -I/home/dzenan/ITK-git/Modules/ThirdParty/VNL/src/vxl/core -I/home/dzenan/ITK-git-rel/Modules/ThirdParty/VNL/src/vxl/v3p/netlib -I/home/dzenan/ITK-git-rel/Modules/ThirdParty/VNL/src/vxl/vcl -I/home/dzenan/ITK-git-rel/Modules/ThirdParty/VNL/src/vxl/core -I/home/dzenan/ITK-git-rel/Modules/Core/Common -I/home/dzenan/ITK-git/Modules/Core/Common/include -I/home/dzenan/ITK-git-rel/Modules/IO/ImageBase -I/home/dzenan/ITK-git/Modules/IO/ImageBase/include -I/home/dzenan/ITK-git/Modules/IO/HDF5/include -I/home/dzenan/ITK-git-rel/Modules/ThirdParty/ZLIB/src -I/home/dzenan/ITK-git/Modules/ThirdParty/ZLIB/src -I/home/dzenan/zarr/ITKIOOMEZarrNGFF/include -I/home/dzenan/zarr/ngff-build/include -I/home/dzenan/zarr/ngff-build/_deps/absl-src -I/home/dzenan/zarr/ngff-build/_deps/upb-src -I/home/dzenan/zarr/ngff-build/_deps/upb-src/upb/reflection/stage0 -I/home/dzenan/zarr/ngff-build/_deps/utf8_range-src -I/home/dzenan/zarr/ngff-build/_deps/protobuf-src/src -I/home/dzenan/zarr/ngff-build/_deps/upb-src/upbc/stage0 -isystem /home/dzenan/ITK-git-rel/Modules/ThirdParty/ZLIB/src/itkzlib-ng -isystem /home/dzenan/ITK-git/Modules/ThirdParty/ZLIB/src/itkzlib-ng -msse2 -O3 -DNDEBUG -fPIE -Wextra -Werror -Wno-stringop-overflow -Wno-unused-parameter -Wno-long-long -Wno-deprecated-declarations -Wno-sign-compare -Wno-unused-but-set-parameter -Wno-maybe-uninitialized -Wno-sequence-point -Wno-unknown-warning-option -fsized-deallocation -std=c++17 -MD -MT _deps/upb-build/CMakeFiles/upb_upbc_protoc-gen-upb_stage0.dir/upbc/protoc-gen-upb.cc.o -MF _deps/upb-build/CMakeFiles/upb_upbc_protoc-gen-upb_stage0.dir/upbc/protoc-gen-upb.cc.o.d -o _deps/upb-build/CMakeFiles/upb_upbc_protoc-gen-upb_stage0.dir/upbc/protoc-gen-upb.cc.o -c /home/dzenan/zarr/ngff-build/_deps/upb-src/upbc/protoc-gen-upb.cc
In file included from /usr/include/string.h:535,
                 from /usr/include/c++/11/cstring:42,
                 from /home/dzenan/zarr/ngff-build/_deps/absl-src/absl/container/internal/container_memory.h:20,
                 from /home/dzenan/zarr/ngff-build/_deps/absl-src/absl/container/flat_hash_map.h:40,
                 from /home/dzenan/zarr/ngff-build/_deps/upb-src/upbc/protoc-gen-upb.cc:39:
In function ‘void* memcpy(void*, const void*, size_t)’,
    inlined from ‘void _upb_MiniTable_CopyFieldData(void*, const void*, const upb_MiniTableField*)’ at /home/dzenan/zarr/ngff-build/_deps/upb-src/upb/message/accessors_internal.h:119:13,
    inlined from ‘void _upb_Message_SetNonExtensionField(upb_Message*, const upb_MiniTableField*, const void*)’ at /home/dzenan/zarr/ngff-build/_deps/upb-src/upb/message/accessors_internal.h:244:31,
    inlined from ‘void google_protobuf_compiler_CodeGeneratorResponse_set_supported_features(google_protobuf_compiler_CodeGeneratorResponse*, uint64_t)’ at /home/dzenan/zarr/ngff-build/_deps/upb-src/upbc/stage0/google/protobuf/compiler/plugin.upb.h:427:36,
    inlined from ‘void upbc::Plugin::ReadRequest()’ at /home/dzenan/zarr/ngff-build/_deps/upb-src/upbc/plugin.h:185:5,
    inlined from ‘upbc::Plugin::Plugin()’ at /home/dzenan/zarr/ngff-build/_deps/upb-src/upbc/plugin.h:83:25,
    inlined from ‘int main(int, char**)’ at /home/dzenan/zarr/ngff-build/_deps/upb-src/upbc/protoc-gen-upb.cc:1710:16:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:29:33: error: ‘void* __builtin_memcpy(void*, const void*, long unsigned int)’ reading 16 bytes from a region of size 8 [-Werror=stringop-overread]
   29 |   return __builtin___memcpy_chk (__dest, __src, __len,
      |          ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
   30 |                                  __glibc_objsize0 (__dest));
      |                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/dzenan/zarr/ngff-build/_deps/upb-src/upbc/protoc-gen-upb.cc: In function ‘int main(int, char**)’:
/home/dzenan/zarr/ngff-build/_deps/upb-src/upbc/protoc-gen-upb.cc:1708:5: note: source object ‘value’ of size 8
 1708 | int main(int argc, char** argv) {
      |     ^~~~
At global scope:
cc1plus: note: unrecognized command-line option ‘-Wno-unknown-warning-option’ may have been intended to silence earlier diagnostics
cc1plus: all warnings being treated as errors
ninja: build stopped: cannot make progress due to previous errors.

[dzenanz]

Does it make sense to tag current master (2917e4d)? Our project builds fine with it. Thank you for your support!

[jbms]

Added a tag.