Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed few bugs in the API and alpha sorted saved searches #1691

Merged
merged 3 commits into from
Mar 17, 2021

Conversation

kiddinn
Copy link
Contributor

@kiddinn kiddinn commented Mar 15, 2021

This PR adds the following things:

  • Alphabetically sorting saved searches, based on the name of the saved search.
  • Adds an additional error handling to the Elastic datastore, to prevent unhandled errors when counting indices.
  • Changes how NAN values are treated in CSV file ingestion. The previous approach was to fill NAN values with an empty string, but that causes issues when the mappings of that field is set to some other value than a text one, for instance a float.
  • Fix issue in error handling of ES ingestion

Checks

  • All tests succeed.
  • Unit tests added.
  • e2e tests added.
  • Documentation updated.

Closing issues

closes #1684

Adds some more error handling to #1687

@google-cla google-cla bot added the cla: yes label Mar 15, 2021
@kiddinn kiddinn changed the title [DRAFT] Changed few things, change name... Fixed few bugs in the API Mar 17, 2021
@kiddinn kiddinn changed the title Fixed few bugs in the API Fixed few bugs in the API and alpha sorted saved searches Mar 17, 2021
@kiddinn kiddinn requested a review from berggren March 17, 2021 10:59
@kiddinn kiddinn marked this pull request as ready for review March 17, 2021 10:59
@berggren berggren merged commit 010d8e8 into google:master Mar 17, 2021
@kiddinn kiddinn deleted the stuff branch March 17, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Explore tab, alphabetical order in saved search queries list
2 participants