Bump com.google.protobuf:protobuf-java from 3.23.2 to 3.23.4 #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [com.google.protobuf:protobuf-java](https://github.com/protocolbuffers/protobuf) from 3.23.2 to 3.23.4. - [Release notes](https://github.com/protocolbuffers/protobuf/releases) - [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl) - [Commits](protocolbuffers/protobuf@v3.23.2...v3.23.4) --- updated-dependencies: - dependency-name: com.google.protobuf:protobuf-java dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
cpovirk
added a commit
that referenced
this pull request
Jul 24, 2023
Notes: - The GWT bump requires changing the browser setting from "FF38" to "FF." - I skipped the `jsinterop-annotations` bump to 2.1.0 because it's built with `-target 11`, while we still support 8. (Closes #1147) (I've noted this in google/guava#6614) - The command I used is: ``` mvn org.codehaus.mojo:versions-maven-plugin:2.16.0:{update-properties,use-latest-releases} -DgenerateBackupPoms=false -Dexcludes=com.google.guava:guava ``` That tried to update protobuf to a release candidate. I had thought that perhaps this was the result of [a protobuf change from "-rc1" to "-rc-1"](protocolbuffers/protobuf#6522), but I'm wondering if it's actually just that `versions-maven-plugin` (in contrast to Dependabot) counts release candidates [as releases](https://www.mojohaus.org/versions/versions-maven-plugin/use-latest-releases-mojo.html)? I'd have to investigate further and perhaps [use `rulesUri`](https://stackoverflow.com/a/46935363/28465). But since we normally rely on Dependabot (and I was using `versions-maven-plugin` here only "to make things easier"... :)), I'm not going to worry about it now. ... Also, it looks like protobuf 4 might remove the `hasPresence()` method that we'd migrated to back in cl/508716698. If so, there's a good chance that the protobuf team will fix things for us :) If not, I'm assuming that this will relate to ["Editions."](https://protobuf.dev/editions/overview/) Fixes #1149 Fixes #1148 Fixes #1146 Fixes #1145
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
Notes: - The GWT bump requires changing the browser setting from "FF38" to "FF." - I skipped the `jsinterop-annotations` bump to 2.1.0 because it's built with `-target 11`, while we still support 8. (Closes #1147) (I've noted this in google/guava#6614) - The command I used is: ``` mvn org.codehaus.mojo:versions-maven-plugin:2.16.0:{update-properties,use-latest-releases} -DgenerateBackupPoms=false -Dexcludes=com.google.guava:guava ``` That tried to update protobuf to a release candidate. I had thought that perhaps this was the result of [a protobuf change from "-rc1" to "-rc-1"](protocolbuffers/protobuf#6522), but I'm wondering if it's actually just that `versions-maven-plugin` (in contrast to Dependabot) counts release candidates [as releases](https://www.mojohaus.org/versions/versions-maven-plugin/use-latest-releases-mojo.html)? I'd have to investigate further and perhaps [use `rulesUri`](https://stackoverflow.com/a/46935363/28465). But since we normally rely on Dependabot (and I was using `versions-maven-plugin` here only "to make things easier"... :)), I'm not going to worry about it now. ... Also, it looks like protobuf 4 might remove the `hasPresence()` method that we'd migrated to back in cl/508716698. If so, there's a good chance that the protobuf team will fix things for us :) If not, I'm assuming that this will relate to ["Editions."](https://protobuf.dev/editions/overview/) Fixes #1149 Fixes #1148 Fixes #1146 Fixes #1145 Fixes #1150 RELNOTES=n/a PiperOrigin-RevId: 550553262
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot
bot
deleted the
dependabot/maven/com.google.protobuf-protobuf-java-3.23.4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps com.google.protobuf:protobuf-java from 3.23.2 to 3.23.4.
Commits
2c5fa07Updating version.json and repo version numbers to: 23.4da85a3aUpdate upb dep to the latest 23.x commit (#13215)571fae4Merge pull request #13106 from chadlwilson/backport-bump-guava-320140d5777deps: Update Guava to 32.0.162d7b37Merge pull request #13090 from fowles/23.x3312fc2update stale files0c70d95Add dllexport_decl for generated default instance. (#13085)528e673Merge pull request #13088 from fowles/23.x1291253Fix a typo6241d42Modify port_def.inc to ignore -Wshadow warning (#13059)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)