Make "value of" lines work with StreamSubject.
#1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
...by migrating off the deprecated no-arg `check()` overload. Usages of that method [cause problems for "value of" lines](https://github.com/google/truth/blob/37fd8bea90c0ab4528c4c922c88fa176eb45f65b/core/src/main/java/com/google/common/truth/FailureMetadata.java#L230-L232). Also, fill in a `typeDescriptionOverride` value for `MultisetSubject`. This is largely a no-op, but it helps under GWT/J2CL (where [we can't infer the type name](https://github.com/google/truth/blob/37fd8bea90c0ab4528c4c922c88fa176eb45f65b/core/src/main/java/com/google/common/truth/super/com/google/common/truth/Platform.java#L72)). I left `IterableSubject` itself without a `typeDescriptionOverride`, since it has subclasses outside the package, some of which may prefer the more specific names (which are normally automatically derived from the `Subject` class's name—e.g., `AttributeListSubject` would result in `value of: attributeList.size()`). In hindsight, I guess that I could have given _direct_ usages of `IterableSubject` a `typeDescriptionOverride` (by making `StandardSubjectBuilder` pass one), but that seems like more effort than is worthwhile now that I've already tested this CL as it stands. RELNOTES=n/a PiperOrigin-RevId: 598964798
copybara-service
bot
force-pushed
the
test_598831653
branch
from
ffcffe6
to
16db780
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make "value of" lines work with
StreamSubject....by migrating off the deprecated no-arg
check()overload.Usages of that method cause problems for "value of" lines.
Also, fill in a
typeDescriptionOverridevalue forMultisetSubject. This is largely a no-op, but it helps under GWT/J2CL (where we can't infer the type name).I left
IterableSubjectitself without atypeDescriptionOverride, since it has subclasses outside the package, some of which may prefer the more specific names (which are normally automatically derived from theSubjectclass's name—e.g.,AttributeListSubjectwould result invalue of: attributeList.size()). In hindsight, I guess that I could have given direct usages ofIterableSubjectatypeDescriptionOverride(by makingStandardSubjectBuilderpass one), but that seems like more effort than is worthwhile now that I've already tested this CL as it stands.RELNOTES=n/a