Skip to content
This repository has been archived by the owner on Nov 9, 2023. It is now read-only.

Multi-facet App ID not compatible with the standard #27

Closed
minisu opened this issue Mar 6, 2015 · 4 comments · Fixed by #28
Closed

Multi-facet App ID not compatible with the standard #27

minisu opened this issue Mar 6, 2015 · 4 comments · Fixed by #28

Comments

@minisu
Copy link

minisu commented Mar 6, 2015

Chrome 41 does not seem to support the TrustedFacets structure that is declared by the specification.

Instead it supports the old, never standardized, way of listing facets which looks like this:

[
"https://accounts.google.com",
"https://myaccount.google.com",
"https://security.google.com"
]

This causes confusion for implementors of U2F.
@slisznia
Copy link

slisznia commented Mar 7, 2015

Thanks a lot for responding to my SO post.

@juanlang
Copy link
Contributor

You're both correct. Sorry for the error. We're working to correct it ASAP.

arnar added a commit that referenced this issue Mar 16, 2015
@arnar
Update to v0.9.22
0d0dc67 
 - Actually follow spec on AppID parsing. Fixes #27
 - Remove infobars in favor of notifications
 - Enforce tab-in-foreground policy to tie user action to origin
 - Store eTLD list in JavaScript to avoid an internal xhr
 - Comment and code-style cleanup for updated Closure
 - Refactoring and minor fixes
@arnar arnar mentioned this issue Mar 16, 2015
Merged
@arnar arnar closed this as completed in #28 Mar 17, 2015
@minisu
Copy link
Author

minisu commented Mar 17, 2015

Thanks @arnar! Will this be merged into Chromium or should I report a separate bug there?

@juanlang
Copy link
Contributor

I just merged this into Chromium:
https://code.google.com/p/chromium/issues/detail?id=471522

It should be available in tonight's nightlies, and starting in Chrome 43.

On Tue, Mar 17, 2015 at 2:02 AM, Henrik Stråth notifications@github.com
wrote:

Thanks @arnar https://github.com/arnar! Will this be merged into
Chromium or should I report a separate bug there?

—
Reply to this email directly or view it on GitHub
#27 (comment).

drewbug pushed a commit to DangerousThings/u2f-chrome-extension that referenced this issue Nov 19, 2015
@arnar
Update to v0.9.22
b75f2be 
 - Actually follow spec on AppID parsing. Fixes google#27
 - Remove infobars in favor of notifications
 - Enforce tab-in-foreground policy to tie user action to origin
 - Store eTLD list in JavaScript to avoid an internal xhr
 - Comment and code-style cleanup for updated Closure
 - Refactoring and minor fixes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to v0.9.22 google/u2f-ref-code
3 participants
@slisznia @minisu @juanlang