-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use MustParse("xxx") instead of Must(Parse("xxxx")) #106
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hello! If you are still interested in making this contribution, please follow the instructions above to sign the CLA. Then, also change the instances of If you are not interested in continuing with this PR, do not respond in a few working days, or do not want to sign the Google CLA, I will make the change myself. Thanks. |
Please address the failed check about commit messages. Other than that I see no problem with this code. |
@noahdietz @bormanp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for the contribution
* fix to use MustParse * use MustParse(...) inseted of Must(Parse(...)) --------- Co-authored-by: Noah Dietz <noahdietz@users.noreply.github.com> Co-authored-by: bormanp <122468813+bormanp@users.noreply.github.com>
Must(Parse("xxxx"))
is considered legacy code to forced uuid to parse because the code is pre-implementation ofMust(Parase("xxxx"))
(#26)This one is simpler.