Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use MustParse("xxx") instead of Must(Parse("xxxx")) #106

Merged
merged 4 commits into from
Feb 22, 2024

Conversation

kotaroyamazaki
Copy link
Contributor

Must(Parse("xxxx")) is considered legacy code to forced uuid to parse because the code is pre-implementation of Must(Parase("xxxx")) (#26)

This one is simpler.

@google-cla
Copy link

google-cla bot commented Sep 16, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@noahdietz noahdietz requested a review from a team as a code owner August 18, 2023 23:07
@noahdietz
Copy link
Collaborator

Hello! If you are still interested in making this contribution, please follow the instructions above to sign the CLA. Then, also change the instances of Must(Parse( in tests to MustParse as well, please.

If you are not interested in continuing with this PR, do not respond in a few working days, or do not want to sign the Google CLA, I will make the change myself. Thanks.

@bormanp
Copy link
Collaborator

bormanp commented Oct 3, 2023

Please address the failed check about commit messages. Other than that I see no problem with this code.

@kotaroyamazaki kotaroyamazaki changed the title fix to use MustParse("xxx") instead of Must(Parse("xxxx")) fix: use MustParse("xxx") instead of Must(Parse("xxxx")) Feb 22, 2024
@kotaroyamazaki
Copy link
Contributor Author

@noahdietz @bormanp
Sorry for the delay. I've fixed the CI error and also updated the test code.

Copy link
Collaborator

@bormanp bormanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the contribution

@bormanp bormanp merged commit 6e10cd1 into google:master Feb 22, 2024
6 checks passed
tkarrass pushed a commit to tkarrass/uuid that referenced this pull request Sep 11, 2024
* fix to use MustParse

* use MustParse(...)  inseted of Must(Parse(...))

---------

Co-authored-by: Noah Dietz <noahdietz@users.noreply.github.com>
Co-authored-by: bormanp <122468813+bormanp@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants