Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector2 constructor benchmark #297

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Conversation

spydon
Copy link
Collaborator

@spydon spydon commented Jun 5, 2023

I worry that these changes may confuse the (somewhat brittle) analysis that allow the length of _v3storage to sometimes become known in the optimizer.

Due to this comment #294 (comment) I wanted to make sure that it wasn't slower to create Vector2 objects with named constructors than with "redirecting" factory constructors. The benchmark shows no sign of it being slower than before.

@rakudrama is there anything I should change, or add, in the benchmark?

@coveralls
Copy link

Coverage Status

coverage: 26.369%. remained the same when pulling 07d97b0 on spydon:vector2_benchmark into a3aca09 on google:master.

@johnmccutchan johnmccutchan merged commit c147038 into google:master Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants