Clean up @all directive and remove args #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| selection[:] = range(len(blocks)) | ||
| else: | ||
| selection[:] = self.blocks | ||
| selection[:] = range(len(blocks)) | ||
| for i in selection: | ||
| if i >= len(blocks): |
There was a problem hiding this comment.
This guard is now protecting against a condition that is not possible (an invalid selection). In fact, the whole loop can be replaced with:
for block in blocks:
block.SetType(True)
There was a problem hiding this comment.
Simplified as suggested. (I'm totally flummoxed by parts of this code and terrified to refactor it 😀)
|
LGTM |
dbarnett
added a commit
that referenced
this pull request
Jul 29, 2014
Clean up @ALL directive and remove args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
@alldirective so it's no longer completely broken (fixes #60).Also removes support for the index args. They're pretty complex to explain, and in practice if anyone did need to add documentation for e.g., 2 of 3 overloaded usages, it wouldn't be that bad to duplicate it. If we end up really needing support for args, we can always add it back later without breaking anyone.
Helps with some
@usageconfusion mentioned in #38.