Follow up to the VectorizedBase refactor with a couple fixes: #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_544696879
branch
3 times, most recently
from
4fcc677
to
4c9e22e
Compare
- Treat `categorical_sizes` constructor arg to Eagle as dynamic instead of static. - Reinstate zeroing of padded dimensions in VectorizedBase to avoid noise in Eagle distance computations. PiperOrigin-RevId: 544709150
copybara-service
bot
force-pushed
the
test_544696879
branch
from
4c9e22e
to
021cf15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to the VectorizedBase refactor with a couple fixes:
categorical_sizesconstructor arg to Eagle as dynamic instead of static.