Clean up & bugfix for random rotation matrix generation. #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_572908132
branch
2 times, most recently
from
96ffa7e
to
e11ee5a
Compare
* It can now handle arbitrarily big seeds. (LRU cache isn't desired because seed can be huge) * Use the scipy sampler which is more accurate and efficient than the custom implementation we had. (LRU isn't needed anymore) * LRU cache is hence removed. PiperOrigin-RevId: 573897020
copybara-service
bot
force-pushed
the
test_572908132
branch
from
e11ee5a
to
116788b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up & bugfix for random rotation matrix generation.