Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring up build infrastructure #1

Closed
jpd236 opened this issue Jan 25, 2017 · 3 comments
Closed

Bring up build infrastructure #1

jpd236 opened this issue Jan 25, 2017 · 3 comments
Assignees
Milestone

Comments

@jpd236
Copy link
Collaborator

jpd236 commented Jan 25, 2017

Includes the following components:

  • Clean up the makefiles (perhaps just use Gradle for everything instead of Maven)
  • Continuous integration builds/tests for commits and pull requests
  • Other useful things to check in CI (e.g. error-prone, google-java-format)
  • Artifact deployment (snapshots on commit, official releases on tags)
@jpd236
Copy link
Collaborator Author

jpd236 commented Sep 27, 2017

Forked off separate bugs for google-java-format and error-prone; these don't need to block the next release.

The only remaining item we need for the next release is ensuring we can promote snapshot builds from OJO to Bintray, including GPG signing, which I'm in the process of investigating.

@jpd236
Copy link
Collaborator Author

jpd236 commented Oct 3, 2017

Unfortunately I'm a bit blocked on GPG signing as I haven't gotten any answers at https://stackoverflow.com/questions/46480065/gpg-signing-snapshots-on-build-promotion-to-bintray around how to GPG sign SNAPSHOT artifacts and/or specify our GPG passphrase when promoting a SNAPSHOT to Bintray. And I really don't want to be publishing an official Volley release from my workstation directly. Currently I'm trying to poke around to see who can answer these questions.

@jpd236
Copy link
Collaborator Author

jpd236 commented Oct 9, 2017

Per JFrog, OJO doesn't support GPG signing for SNAPSHOT artifacts or signing at promotion time via snapshotsToBintray. However, we should be able to sign them manually after the fact. There'll be a brief window where they are not signed, but if all goes well, not much of one.

Will take a shot at this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant