Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/wire: move field name into ProviderInput #104

Merged
merged 2 commits into from
Jan 23, 2019

Conversation

zombiezen
Copy link
Collaborator

Avoids having parallel arrays for conceptually related data.

Avoids having parallel arrays for conceptually related data.
@zombiezen zombiezen requested a review from shantuo January 7, 2019 22:30
@googlebot googlebot added the cla: yes Google CLA has been signed! label Jan 7, 2019
Copy link
Contributor

@doodlesbykumbi doodlesbykumbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, LGTM, though it needs a rebase!

@zombiezen
Copy link
Collaborator Author

@shantuo, ping?

Copy link
Contributor

@shantuo shantuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response!

@zombiezen zombiezen merged commit 3b0186f into google:master Jan 23, 2019
@zombiezen zombiezen deleted the provider-input-todo branch January 23, 2019 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA has been signed!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants