Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce wireit 'lint' command #807

Open
kwangure opened this issue Jul 10, 2023 · 2 comments
Open

Introduce wireit 'lint' command #807

kwangure opened this issue Jul 10, 2023 · 2 comments

Comments

@kwangure
Copy link

The Wireit VS Code extension is extremely helpful for immediately spotting errors in the open package.json. If you modify a package.json such that it is correct, but it invalidates the correctness of another that's not open you wont see it that error. A wireit lint command checks all packages would be a helpful addition to git hooks or CI linting.

@leadoflife
Copy link

Also, Git Hooks and CI could simply build on top of WireIt linting. For example, using a Husky git hook to call WireIt's linting command

@luke-lacroix-healthy
Copy link

In addition to what was stated above, I would also like to add that not everyone uses VSCode.

Are there any maintainers that can weigh in on this? Would a PR be accepted? Or is the expectation that this would be handled by an external tool, much in the way that the VSCode extension is external to wireit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants