Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the CMake build system. #92

Merged
merged 1 commit into from
Oct 5, 2017
Merged

Conversation

rsheeter
Copy link
Contributor

@rsheeter rsheeter commented Oct 5, 2017

This brings various improvements to the current Makefile and intends to help
people to package WOFF2:

  • Build and install static and shared libraries for encoder and decoder
  • Install public headers
  • Generate and install pc files for PkgConfig
  • Build the woff2_* programs
  • Build the fuzzer archives
  • Specify a release version (0.0.1 is hardcoded for now)
  • Build using a Brotli version installed on the system, instead of the git
    submodule
  • Have some CANONICAL_PREFIXES and NOISY_LOGGING configuration options

This brings various improvements to the current Makefile and intends to help
people to package WOFF2:

* Build and install static and shared libraries for encoder and decoder
* Install public headers
* Generate and install pc files for PkgConfig
* Build the woff2_* programs
* Build the fuzzer archives
* Specify a release version (0.0.1 is hardcoded for now)
* Build using a Brotli version installed on the system, instead of the git
  submodule
* Have some CANONICAL_PREFIXES and NOISY_LOGGING configuration options
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@rsheeter
Copy link
Contributor Author

rsheeter commented Oct 5, 2017

Cherrypick of the CMake file changes only from PR. OK per @fred-wang comment on #91

@rsheeter rsheeter merged commit 22c256b into google:master Oct 5, 2017
@fred-wang
Copy link
Contributor

@rsheeter Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants