Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ProductModuleName with dashes #42

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Fix ProductModuleName with dashes #42

merged 1 commit into from
Mar 18, 2022

Conversation

keith
Copy link
Contributor

@keith keith commented Feb 4, 2022

@keith keith mentioned this pull request Feb 28, 2022
Open
@keith
Copy link
Contributor Author

keith commented Feb 28, 2022

@albertdai can you review?

@albertdai albertdai merged commit e0bc4b2 into google:master Mar 18, 2022
@mattrobmattrob mattrobmattrob mentioned this pull request Mar 17, 2023
Merged
mattrobmattrob added a commit to bazelbuild/rules_apple that referenced this pull request Mar 17, 2023
@mattrobmattrob
Fix test_filter support in ios_xctestrun_runner (#1907)
d3bcd9f 
# Summary
Build off of #1900 to correct the use of `--test_filter` to select individual tests vs. just exclusions.

- This uses the approach from #1361 / #1369 to ensure the `module_name` of the underlying Swift test lib has a matching `module_name` equal to the test bundle.
- Now substitutes `ProductModuleName` in all `xctestrun`s using the name of the test bundle.
- Might also be worth applying this substitution for module name down the road: google/xctestrunner#42

Fixes #1899.

# Testing
```bash
$ bazel test //test:ios_xctestrun_runner_ui_test
INFO: Analyzed target //test:ios_xctestrun_runner_ui_test (0 packages loaded, 0 targets configured).
INFO: Found 1 test target...
Target //test:ios_xctestrun_runner_ui_test up-to-date:
  bazel-bin/test/ios_xctestrun_runner_ui_test
INFO: Elapsed time: 86.325s, Critical Path: 86.19s
INFO: 2 processes: 1 internal, 1 darwin-sandbox.
INFO: Build completed successfully, 2 total actions
//test:ios_xctestrun_runner_ui_test                                      PASSED in 84.4s

Executed 1 out of 1 test: 1 test passes.
There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.

$ bazel test //test:ios_xctestrun_runner_unit_test
INFO: Analyzed target //test:ios_xctestrun_runner_unit_test (1 packages loaded, 6 targets configured).
INFO: Found 1 test target...
Target //test:ios_xctestrun_runner_unit_test up-to-date:
  bazel-bin/test/ios_xctestrun_runner_unit_test
INFO: Elapsed time: 134.572s, Critical Path: 134.41s
INFO: 5 processes: 4 internal, 1 darwin-sandbox.
INFO: Build completed successfully, 5 total actions
//test:ios_xctestrun_runner_unit_test                                    PASSED in 133.4s

Executed 1 out of 1 test: 1 test passes.
There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are
```
mattrobmattrob added a commit to bazelbuild/rules_apple that referenced this pull request Mar 17, 2023
@mattrobmattrob
Correct xctestrun ProductModuleName with underscores
f9c9e75 
In response to #1907 (review), replicate google/xctestrunner#42 in `ios_xctestrun_runner`.
@mattrobmattrob mattrobmattrob mentioned this pull request Mar 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentleyjones brentleyjones brentleyjones approved these changes

@albertdai albertdai albertdai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keith @brentleyjones @albertdai