[c_api] Break C API monolith into multiple sub-targets. #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richmckeever
approved these changes
Sep 24, 2024
proppy
reviewed
Sep 24, 2024
xls/public/c_api_impl_helpers.cc
Outdated
|
|
||
| #include "xls/public/c_api_impl_helpers.h" | ||
|
|
||
| #include <filesystem> |
There was a problem hiding this comment.
Done, though note it's hard to anticipate what the linter will do for contributors, I don't think it's externally available right?
There was a problem hiding this comment.
Done, though note it's hard to anticipate what the linter will do for contributors, I don't think it's externally available right?
@hzeller was mentioning it would be nice to add the NOLINT annotation on import, or make sure we enforce the check externally (maybe enforcing xls::common::Filesystem usage?)
proppy
reviewed
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since VAST is now in there (as a conceptually "protected" / more prone to change API) with the other public APIs seemed like a good time to break it into some translation units before introducing more "protected" APIs e.g. for DSLX inspection.