Ptr::try_cast_into takes explicit element count #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
force-pushed
the
zst-count
branch
2 times, most recently
from
0c4e84d
to
5769517
Compare
joshlf
commented
May 3, 2024
joshlf
force-pushed
the
ptr-split
branch
6 times, most recently
from
0736e85
to
447fee9
Compare
jswrenn
requested changes
May 7, 2024
joshlf
commented
May 10, 2024
joshlf
commented
May 10, 2024
joshlf
force-pushed
the
zst-count
branch
2 times, most recently
from
acbfd9d
to
b86a264
Compare
jswrenn
force-pushed
the
zst-count
branch
2 times, most recently
from
916e2bf
to
666fd3a
Compare
joshlf
force-pushed
the
zst-count
branch
2 times, most recently
from
63fab2e
to
da6aee6
Compare
joshlf
changed the title
This permits us use `Ptr::try_cast_into` directly (rather than using `Ref`) in `FromBytes` methods that take an explicit element count. This, in turn, allows those methods to support DSTs with zero-sized trailing slice elements. Makes progress on #29
jswrenn
approved these changes
May 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.