[ci] Run Miri test alias models in parallel #1311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [ci] Run Miri tests on multiple threads Use `cargo nextest` to run Miri tests on twice the number of threads as there are CPU cores. * Split `test_ptr_try_cast_into_soundness` This should enable better parallelization, especially under Miri in CI. Comparing [1] (run with the parent commit) and [2] (run with this commit), we see an overall speedup of 22m51s -> 18m28s, or ~19%. [1] https://github.com/google/zerocopy/actions/runs/9148942749 [2] https://github.com/google/zerocopy/actions/runs/9148952446
In CI, we run Miri tests using both the Stacked Borrows and Tree Borrows aliasing models. This commit runs these in parallel to improve utilization of available parallelism.
joshlf
force-pushed
the
ci-miri-parallelize
branch
from
8952642
to
0132ae0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## ptr-test-parallelize-tmp #1311 +/- ##
============================================================
- Coverage 87.84% 87.71% -0.13%
============================================================
Files 15 15
Lines 5191 5138 -53
============================================================
- Hits 4560 4507 -53
Misses 631 631 ☔ View full report in Codecov by Sentry. |
|
This workflow run took 18m50s, which is within error bars of the previous times. I'm going to close this as not buying us enough to justify the added complexity. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CI, we run Miri tests using both the Stacked Borrows and Tree Borrows aliasing models. This commit runs these in parallel to improve utilization of available parallelism.