[ci.yml] Test zerocopy-derive in CI #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
force-pushed
the
test-derive
branch
6 times, most recently
from
cb75d88
to
2c218fa
Compare
In some cases, zerocopy-derive performs its analysis by emitting code which the Rust compiler will reject if implementing a particular trait would not be sound. This means that, when the rustc's error messages change, so do zerocopy-derive's. We have "UI" tests which attempt to comile invalid code, and expect that it is rejected in the appropriate way. These tests are dependent upon the exact error messages produced in different cases. Since rustc sometimes changes its error messages between versions, this means that a single set of UI tests cannot be correct for all Rust versions. In this commit, we split our UI tests - we keep one copy of the source `.rs` files, but multiple copies of the expected error messages, one per toolchain pinned in CI.
joshlf
added a commit
that referenced
this pull request
Aug 3, 2023
In some cases, zerocopy-derive performs its analysis by emitting code which the Rust compiler will reject if implementing a particular trait would not be sound. This means that, when the rustc's error messages change, so do zerocopy-derive's. We have "UI" tests which attempt to comile invalid code, and expect that it is rejected in the appropriate way. These tests are dependent upon the exact error messages produced in different cases. Since rustc sometimes changes its error messages between versions, this means that a single set of UI tests cannot be correct for all Rust versions. In this commit, we split our UI tests - we keep one copy of the source `.rs` files, but multiple copies of the expected error messages, one per toolchain pinned in CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.