Fix Rust Cache invalid key warning #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
requested changes
Oct 14, 2022
joshlf
requested changes
Oct 14, 2022
joshlf
pushed a commit
that referenced
this pull request
Aug 3, 2023
The `Swatinem/rust-cache` GitHub action does not support commas in its cache key, but we use the Cargo feature set (which can have commas) as part of the cache key. This commit hashes the feature set to avoid this problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #43 by using the length of the feature string instead of the features themselves. This avoids the commas which were causing the issues and the key should be unique so long as the feature strings are of different lengths (which for the time being is the case).