Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EXCEPT DISTINCT parsed to EXCEPT ALL + order_by and window_frame are an optional field #82

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

EXCEPT DISTINCT parsed to EXCEPT ALL + order_by and window_frame are an optional field #82

wants to merge 3 commits into from

Conversation

JordyHeusdensDT
Copy link

  • EXCEPT DISTINCT is mapped to EXCEPT ALL after being parsed, this is now fixed
  • order_by in ResolvedAnalyticFunctionGroup can be NULL and should thus be optional
  • window_frame in ResolvedAnalyticFunctionCall can be NULL and should thus be optional

This was referenced Jan 7, 2022
Open
Open
Open
@tristan-vt
Copy link

This solves some bugs I've been having for quite a while

matthewcbrown pushed a commit that referenced this pull request Feb 16, 2022
@matthewcbrown
Export of internal ZetaSQL changes.
74ce04b 
 Major changes:
   We now require bazel 4.0.0
   GRPC and Protobuf have been upgraded
    -  Older version may still work, but are not being tested
   Mac builds should be improved
   WORKSPACE management is different (if you require java), please
     see WORKSPACE file for more info
   maven_install rule is now used for java dependencies, which may
   affect how bazel-based java builds work.


--
Change by Matthew Brown <matthewbr@google.com>:
Fix some spammy warnings in ZetaSQL
--
Change by ZetaSQL Team <no-reply@google.com>:
Fix interactions between joins and value tables
--
Change by ZetaSQL Team <no-reply@google.com>:
Use the KW_EXCEPT_IN_SET_OP constant rather than a string in the grammar.
--
Change by Matthew Brown <matthewbr@google.com>:
 Fix macos Builds in ZetaSQL
 - Clang-based builds (like the default on mac) seem to have trouble with
   some of the gcc-style warning suppression - so we just spam out
   all the warnings.
 - Some high-frequency warnings will be cleaned up in a follow-on CL
--
Change by ZetaSQL Team <no-reply@google.com>:
Add annotation to error message when casting a STRING to INTERVAL, which is not a valid INTERVAL value.
--
Change by ZetaSQL Team <no-reply@google.com>:
Fixes SqlBuilder component for `EXCEPT DISTINCT` statements and adds a regression test.
Bug identified by GitHub user @JordyHeusdensDT and fix first proposed in #82
--
Change by ZetaSQL Team <no-reply@google.com>:
INTERNAL
--
Change by ZetaSQL Team <no-reply@google.com>:
rename tvf_bad_call_error_message to mismatch_message.
--
Change by Matthew Brown <matthewbr@google.com>:
ZetaSQL: Upgrade GRPC
--
Change by ZetaSQL Team <no-reply@google.com>:
Switch Value::Struct to Value::MakeStruct to handle errors gracefully.
--
Change by ZetaSQL Team <no-reply@google.com>:
INTERNAL
--
Change by Matthew Brown <matthewbr@google.com>:
ZetaSQL: Upgrade several java dependencies to newer versions
--
Change by ZetaSQL Team <no-reply@google.com>:
Remove some dead code.
--
Change by Matthew Brown <matthewbr@google.com>:
Stop storing a pointer to language options (make a copy instead)
--
Change by Matthew Brown <matthewbr@google.com>:
Propagate language options into parser when resolving TemplatedSqlUdf
--
Change by ZetaSQL Team <no-reply@google.com>:
Add COTH to ZetaSQL as part of adding new math functions
--
Change by ZetaSQL Team <no-reply@google.com>:
Add SECH to ZetaSQL as part of adding new math functions
--
Change by ZetaSQL Team <no-reply@google.com>:
Add CSCH to ZetaSQL as part of adding new math functions
--
Change by Matthew Brown <matthewbr@google.com>:
ZetaSQL: Require bazel 4.0.0+
--
Change by ZetaSQL Team <no-reply@google.com>:
Fix RET_CHECK failure in ResolveArrayElement related to FLATTEN.
--
Change by ZetaSQL Team <no-reply@google.com>:
Documentation for braced new constructors.
--
Change by Matthew Brown <matthewbr@google.com>:
ZetaSQL: Update protobuf version to 3.19.3
GitOrigin-RevId: 185a07d6cd6ba697ac569f3df298f9a38b24e51c
Change-Id: I454d4947229bb3aa51706923e37f55ab0919eb0b
@renovate renovate bot mentioned this pull request Apr 5, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tristan-vt tristan-vt tristan-vt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JordyHeusdensDT @tristan-vt