Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gerrit mirror #110

Closed
wants to merge 2 commits into from
Closed

Gerrit mirror #110

wants to merge 2 commits into from

Conversation

kepeket
Copy link
Contributor

@kepeket kepeket commented Feb 28, 2020

Add the ability to handle Gerrit mirrors in the zoekt-indexserver command config file.

[
{
        "GerritApiUrl": "https://gerrit.host.com/",
        "Name": "project/", // pattern to browse
        "CredentialPath": "htt_pusername:http_password",
        "Exclude": "[A-Z]+.*" //regex pattern to exlude matches
    }
]

Kevin PRETTRE added 2 commits February 28, 2020 16:04
indexserver cmd config file was not including Gerrit type
mirror. It handles http basic auth in a CredentialPath entry
and call zoekt-mirror-gerrit with the according flags.

It also implement gerrit default weblink implementation of
Gitiles (WebLink.Name = browse)
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@kepeket
Copy link
Contributor Author

kepeket commented Feb 28, 2020

@googlebot I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@kepeket
Copy link
Contributor Author

kepeket commented Feb 28, 2020

Don't mind reviewing this PR, I'll send my change on Gerrit. Sry for the noise.

@kepeket kepeket closed this Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants