Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ** for LargeFiles patterns. #135

Closed
wants to merge 1 commit into from

Conversation

rmmh
Copy link
Contributor

@rmmh rmmh commented Jun 3, 2021

This is done by simply changing from filepath.Match to
doublestar.PathMatch. A few minor tests are included.

The only syntax change is that ** now matches any number of directories,
so "/*.lock" will match a file with a "lock" extension anywhere in the
path. Since "
" had no special meaning before, this change should not
cause any surprising changes.

This is done by simply changing from filepath.Match to
doublestar.PathMatch. A few minor tests are included.

The only syntax change is that ** now matches any number of directories,
so "**/*.lock" will match a file with a "lock" extension anywhere in the
path. Since "**" had no special meaning before, this change should not
cause any surprising changes.
@google-cla
Copy link

google-cla bot commented Jun 3, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@rmmh
Copy link
Contributor Author

rmmh commented Jun 3, 2021

@googlebot I fixed it.

@hanwen
Copy link
Contributor

hanwen commented Jun 7, 2021

can you send a review through Gerrit as documented in CONTRIBUTING ?

@rmmh
Copy link
Contributor Author

rmmh commented Jun 7, 2021

@rmmh rmmh closed this Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants