-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OnUserEarnedReward is called after OnAdClosed in Android Device #1689
Comments
The callback order is dependent on the adapter implementations, and typically the limiting factor is we rely on the events from the 3p SDK to then forward onto you. In this case, you're using AppLovin -- it's possible their SDK returns ad closed callback before the ad reward callback, in which case there's not much we can do about it. Holding the call to onAdClosed() until the rewarded callback is invoked is risky, because we don't know that the reward callback will happen 100% of the time. @joshuajplagonera to dig into the AppLovin Android adapter and confirm the behavior. |
@ericleich why no one of your team is answering to my question? What is the problem. |
@Archi97 the other 3 should all be commented now. |
Hi All, We currently forward |
@NVentimiglia to take a look. The Unity plugin does do some threading/queueing with events that come back, and the logs above do make it seem like the plugin is mishandling a race condition. |
Callback order wery poorly described. I use async (task or coroutine) to handle callbacks. After i receive onAdClosed i wait several frames for onUserEarnedReward and if it not happend - consider it as skipped (canceled) ad |
I took a look at this issue and was unable to replicate on my first pass. Here are my steps.
Is there something I missed ? |
Hello. The only difference here - it was used Rewarded Ad instead of Rewarded Interstitial Ad. |
Ok, I am still unable to replicate. What I would like you to do is open up a case here, on the google admob sdk support group and link this github issue. If you can include a minimal sample of this issue, I would love to fix this. |
I was unable to replicate this issue with the AppLovin plugin. When testing AdReword showed before AdClose, as expected. I have included my demo code below.
|
Got OnAdReceivedReward callback just after OnAdClosed fired(or even not called). Found this issue when show UnityAds ads through mediation. Admob version is 7.0.1, Unity 2020.3.35 |
Step 0: Are you in the right place?
your app, reach out to our support team on the
Developer Forum.
AdMob Support.
send your feedback by pressing the Send Feedback button at the top right of the
documentation page you are on.
[REQUIRED] Step 1: Describe your environment
[REQUIRED] Step 2: Describe the problem
Steps to reproduce:
OnUserEarnedReward event is called after OnAdClosed in Android device.
For test purposes, it was used HelloWorld example project with mediation ad networks described above, and with real adUnitId(https://github.com/googleads/googleads-mobile-unity/tree/master/samples/HelloWorld)
Screenshot with the log:
The last message after closing the ad was User Earned Reward instead of Ad Closed
The text was updated successfully, but these errors were encountered: