fix(AIP-203): remove resource name identifier suggestion (#1263)

googleapis · Oct 5, 2023 · 687fe7f · 687fe7f
1 parent 34f6df3
commit 687fe7f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/rules/aip0203/resource_name_identifier.go b/rules/aip0203/resource_name_identifier.go
@@ -33,7 +33,6 @@ var resourceNameIdentifier = &lint.MessageRule{
 				Message:    "resource name field must have field_behavior IDENTIFIER",
 				Descriptor: f,
 				Location:   locations.FieldOption(f, fpb.E_FieldBehavior),
-				Suggestion: "(google.api.field_behavior) = IDENTIFIER",
 			}}
 		}
 

diff --git a/rules/aip0203/resource_name_identifier_test.go b/rules/aip0203/resource_name_identifier_test.go
@@ -40,12 +40,12 @@ func TestResourceNameIdentifier(t *testing.T) {
 		{
 			name:     "InvalidNoFieldBehavior",
 			Field:    "string name = 1;",
-			problems: testutils.Problems{{Message: "field_behavior IDENTIFIER", Suggestion: "(google.api.field_behavior) = IDENTIFIER"}},
+			problems: testutils.Problems{{Message: "field_behavior IDENTIFIER"}},
 		},
 		{
 			name:     "InvalidMissingIdentifier",
 			Field:    "string name = 1 [(google.api.field_behavior) = REQUIRED];",
-			problems: testutils.Problems{{Message: "field_behavior IDENTIFIER", Suggestion: "(google.api.field_behavior) = IDENTIFIER"}},
+			problems: testutils.Problems{{Message: "field_behavior IDENTIFIER"}},
 		},
 	}