This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
fix: correctly propagate the firebase app name #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
Codecov ReportBase: 65.88% // Head: 65.54% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1122 +/- ##
==========================================
- Coverage 65.88% 65.54% -0.34%
==========================================
Files 21 21
Lines 1791 1791
Branches 355 355
==========================================
- Hits 1180 1174 -6
- Misses 524 526 +2
- Partials 87 91 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jasonborg
approved these changes
Dec 15, 2022
mctavish
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
mctavish
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Dec 15, 2022
🤖 I have created a release *beep* *boop* --- ## [7.2.1](https://togithub.com/googleapis/cloud-debug-nodejs/compare/v7.2.0...v7.2.1) (2022-12-15) ### Bug Fixes * Correctly propagate the firebase app name ([#1122](https://togithub.com/googleapis/cloud-debug-nodejs/issues/1122)) ([443e902](https://togithub.com/googleapis/cloud-debug-nodejs/commit/443e902c9d702ea1869e5e68d709f3e6ee14485c)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The firebase app name is not being correctly set and in at least some cases will prevent the debug agent from connecting to the firebase database.