Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental postgres plugin #402

Merged
merged 1 commit into from
Mar 7, 2017
Merged

Experimental postgres plugin #402

merged 1 commit into from
Mar 7, 2017

Conversation

matthewloring
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 19, 2017
@ofrobots ofrobots mentioned this pull request Mar 1, 2017
Closed
kjin
kjin reviewed Mar 2, 2017
View reviewed changes
Copy link
Contributor

@kjin kjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if queries are canceled? Do we want to support ending traces when that happens?

src/plugins/plugin-pg.js Outdated

var SUPPORTED_VERSIONS = '^6.x';

function makeQueryWrap(api) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

src/plugins/plugin-pg.js Outdated
span.addLabel('error', err);
}
if (res) {
// TODO(mattloring): summarize once it is available on the public api

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@kjin
Copy link
Contributor

kjin commented Mar 2, 2017 •
edited
Loading

If it helps, you can apply this patch on top of this PR once you rebase to reflect changes since the PR was first opened: kjin@dd50a45

@matthewloring
Copy link
Contributor Author

Thank you very much for putting together the patch you linked! On cancelation, if the request has been buffered but not sent, then no async work has actually been done and there is no span to report. If the request has been sent and is canceled in flight then I think it should resolve normally with information in the response indicating that it was canceled (we should verify this though).

kjin
kjin approved these changes Mar 7, 2017
View reviewed changes
Copy link
Contributor

@kjin kjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@matthewloring matthewloring merged commit 1ab25b2 into googleapis:master Mar 7, 2017
@matthewloring matthewloring deleted the postgres branch March 7, 2017 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjin kjin kjin approved these changes

@ofrobots ofrobots Awaiting requested review from ofrobots

@cristiancavalli cristiancavalli Awaiting requested review from cristiancavalli

@DominicKramer DominicKramer Awaiting requested review from DominicKramer

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewloring @kjin @googlebot