Skip to content
This repository has been archived by the owner on Dec 22, 2021. It is now read-only.

ci: add configs for a CMake+Ninja build #27

Merged
merged 1 commit into from
Oct 17, 2019
Merged

ci: add configs for a CMake+Ninja build #27

merged 1 commit into from
Oct 17, 2019

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Oct 17, 2019

This is part of the work for #25, we also need to make the corresponding changes inside Google.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 17, 2019
@coryan coryan requested a review from tmatsuo October 17, 2019 18:47
@coryan coryan merged commit 449df1f into googleapis:master Oct 17, 2019
@coryan
Copy link
Contributor Author

coryan commented Oct 17, 2019

Ooops, I was able to merge without a review. @tmatsuo let me know if I should fix anything, I will setup the branch protections in a minute.

@coryan coryan deleted the configure-ninja-ci-build branch October 17, 2019 18:48
Copy link
Contributor

@tmatsuo tmatsuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry about not setting the protection in place, it LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants