Skip to content
This repository has been archived by the owner on Dec 22, 2021. It is now read-only.

feat: add storage protos #39

Merged
merged 3 commits into from
Feb 25, 2020
Merged

feat: add storage protos #39

merged 3 commits into from
Feb 25, 2020

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Feb 25, 2020

Fixes #36


This change is Reviewable

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 25, 2020
@coryan coryan marked this pull request as ready for review February 25, 2020 19:10
Copy link

@mr-salty mr-salty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @coryan, @devbww, @devjgm, and @scotthart)


CMakeLists.txt, line 333 at r1 (raw file):

Quoted 4 lines of code…
# for proto in "${protos[@]}"; do (cd cmake-build-
# debug/external/googleapis/src/googleapis_download; grep -H '^import '
# "${proto}" | grep -v google/protobuf); done | sed -e 's;google/;;g' -e
# 's/:import "/ /' -e 's/";//' -e 's;/;_;g' -e 's/\.proto/_protos/g'

Is this left over from something? looks like it's got line breaks in the wrong places

@coryan coryan merged commit c873fd3 into googleapis:master Feb 25, 2020
@coryan coryan deleted the add-storage-protos-pr2 branch February 25, 2020 19:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update protos to include the google/storage/v1
3 participants