This repository has been archived by the owner on Dec 22, 2021. It is now read-only.
fix: avoid warnings with newer CMake versions #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed this with CMake 3.17.1, but may have started earlier. Using `include()` to load a module does not work because the calls to `find_package_handle_standard_args()` generate a ton of warnings. Loading the module using `find_package()` works as expected.
googlebot
added
the
cla: yes
mr-salty
approved these changes
Apr 23, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @devbww, @devjgm, and @scotthart)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this with CMake 3.17.1, but may have started earlier. Using
include()to load a module does not work because the calls tofind_package_handle_standard_args()generate a ton of warnings.Loading the module using
find_package()works as expected.Part of the work for googleapis/google-cloud-cpp#3892
This change is