Skip to content
This repository has been archived by the owner on Dec 22, 2021. It is now read-only.

Refactor Dockerfiles #6

Merged
merged 1 commit into from
Jul 12, 2019
Merged

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Jul 11, 2019

Fixes #5

@tmatsuo tmatsuo requested a review from coryan July 11, 2019 23:44
@tmatsuo tmatsuo added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 11, 2019
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Jul 11, 2019

Kokoro should run the presubmit tests, but they're failing. I need to know why.

Update: We're using our own github token. I needed to add yoshi-kokoro as a collaborator. Now everything seems good.

@tmatsuo tmatsuo added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 11, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 12, 2019
@tmatsuo tmatsuo removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 12, 2019
@tmatsuo tmatsuo merged commit d6e90be into googleapis:master Jul 12, 2019
@tmatsuo tmatsuo deleted the dockerfile-refactor branch July 12, 2019 17:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split Dockerfiles for Ubuntu 18.04 and Ubuntu 16.04
3 participants