Skip to content
This repository has been archived by the owner on Feb 28, 2023. It is now read-only.

fix: ReadMe Updates #25

Merged
merged 5 commits into from
Dec 3, 2020
Merged

fix: ReadMe Updates #25

merged 5 commits into from
Dec 3, 2020

Conversation

dh--
Copy link
Contributor

@dh-- dh-- commented Sep 15, 2020

Fixed a typo in the readme, and made some stylistic changes.

Added a 'Contributing' section, borrowed from the go libraries project.

De-dupe the code of conduct, preference given to the last updated version.

Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to README are included in PR

Fixed a typo in the readme, and made some stylistic changes.

Added a 'Contributing' section, borrowed from the go libraries project.

De-dupe the code of conduct, preference given to the last updated version.
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 15, 2020
Fixed a typo in the readme, and made some stylistic changes.

Added a 'Contributing' section, borrowed from the go libraries project.

De-dupe the code of conduct, preference given to the last updated version.
@dh-- dh-- changed the title ReadMe Updates fix: ReadMe Updates Sep 16, 2020
@tbpg
Copy link
Contributor

tbpg commented Sep 18, 2020

Hey! Thanks for the PR! I just saw this. Would you mind fixing the conflict in the readme? The short version of the contributing section is probably enough. But, I would appreciate the typo fix at the top.

@dh-- dh-- requested a review from a team as a code owner December 3, 2020 15:09
Copy link
Contributor

@tbpg tbpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the PR to resolve the conflict. Thank you!

@tbpg tbpg added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 3, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 3, 2020
@tbpg tbpg merged commit df702ab into googleapis:master Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants