First pass tests and impl for PageResult #50
Conversation
In order to support multiple use cases and extreme customizations, not to mention making a more modular, well-designed, and helpful implementation, paginated method results will be based on three classes and corresponding iterators. This is the commit for PageResult, which is a gax-owned type that provides a consistent interface over individual result pages.
software-dov
requested review from
coryan,
devjgm,
devbww,
michaelbausor and
vam-google
googlebot
added
the
cla: yes
ElementAccessor is now a template parameter The type of the iterator over the repeated field is now deduced.
software-dov
requested review from
coryan and
vam-google
and removed request for
coryan
gax/pagination_test.cc
Outdated
| page_result.RawPage().next_page_token()); | ||
| EXPECT_EQ(page_result.RawPage().operations_size(), 10); | ||
|
|
||
| // Move iteration test |
There was a problem hiding this comment.
Ignore this, fixed in local repo.
|
|
||
| iterator(FieldIterator current) : current_(std::move(current)) {} | ||
|
|
||
| FieldIterator current_; |
There was a problem hiding this comment.
For my edification, what is the reason for having the using FieldIterator = ... statement be private inside PageResult, but exposed publicly here? Is this intentional, and provides some benefit?
There was a problem hiding this comment.
It was not intentional, but it is also not intended to be a user-visible type. It makes more sense when the constructor is private.
Proper access control hygiene is something I'm working on, and I plan on doing a comprehensive pass of the codebase as part of maintenance later on.
|
|
||
| FieldIterator current_; | ||
| }; | ||
| // Note: Since the constructor will eventually be private (with friend |
There was a problem hiding this comment.
When is eventually? In followup PRs adding the other classes supporting pagination?
There was a problem hiding this comment.
Yes. The immediate followup PR is mostly finished and makes the constructor private with friend access granted to other implementation classes. The current setup is partly a memory aid/habit I want to form to prevent overreliance on FRIEND_TEST.
In order to support multiple use cases and extreme customizations,
not to mention making a more modular, well-designed,
and helpful implementation, paginated method results will be based on three classes
and corresponding iterators.
This is the commit for PageResult, which is a gax-owned type that provides a thin, consistent interface
over individual result pages. Its primary purpose is to add C++ iterators over the repeated elements embedded in the page message.